Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Upgrade from Travis to GH Actions #57

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Upgrade from Travis to GH Actions #57

merged 1 commit into from
Apr 2, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Apr 2, 2020

This PR upgrades this repository to use Github Actions for CI.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😄

runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 13.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: this PR updates the Node versions tested from 8, 10, 11 to 10, 12, 13.

@holgerd77
Copy link
Member

Have also adjusted the checks required. Coveralls is now additionally required and I added some reasonable thresholds for failure (e.g. to be a bit flexible on slight coverage decreases e.g. on one-liner-additions).

@PhilippLgh Informational side note: stuff like this absolutely doesn't need to go through my hands in any way, feel very free to settle further PRs directly with Ryan (or whoever) on occasion if you feel confident on being able to review. I was just randomly at the desk and already had reviewed some of Ryans GitHub-Actions-PRs so I took the occasion.

@holgerd77 holgerd77 merged commit 672142e into master Apr 2, 2020
@holgerd77 holgerd77 deleted the addGhActions branch April 2, 2020 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants