This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing Istanbul gas costs for:
Wasn't sure about this referenced
G_BASE
parameter for the ChainID opcode addition mentioned in the EIP. Py-EVM is just integrating it as a generic constant. I did a parameter search in Common and the VM and couldn't find a reference to that (maybe I missed), so I decided to add this here in a generic way to chainstart.Maybe @rmeissner - who worked out the EIP and also did some work on the VM - could help with a comment on that.