Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

New release v1.2.1 (added draft EIP-1108 alt_bn128 gas costs) #53

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

holgerd77
Copy link
Member

After reading this tweet I thought it would actually be fun to directly start integrating a first EIP in the v4 release of the VM.

There is all this talk on the AllCoreDevs Gitter channel on reference implementations of EIPs, since this time there seems to be the need of some "Champion", so 1-2 implementations of EIPs until they get accepted, as far as I understand also for the more simple onces (since it wouldn't make sense to draw some line here (where to draw?).).

EIP-1108 is a good fit for a start, since while really simple it has large benefits and would help Aztec privacy protocol a lot, on the same time it's really easy for us here to integrate.

I think this also has very much some real world use, since people then have some first tool to run there contracts against which can be used to develop some feeling for the changing gas costs and investigate further respectively prepare.

Beside it would draw some attention to the VM 😋 (I think it would really deserve some more). Our VM is actually generally very much suited for experimentation like this, since JavaScript is pretty accessible for many people. Maybe we can establish a bit in the whole process as some research VM and eventually also get some implementations for free along the process. 😄 😛 Especially for people coming from the outside with not too deep VM knowledge yet it's then pretty valuable to have a first EIP implementation done which one can reference and go along on own implementations.

I've also directly integrated the release bump and preparation, since I think these one-by-one additions of EIP parameters for Istanbul on this library will be pretty deterministic in release planning and should ease the process a bit.

@holgerd77 holgerd77 requested review from alcuadrado and s1na June 1, 2019 05:35
@s1na
Copy link
Contributor

s1na commented Jun 3, 2019

Great initiative Holger!

Yeah as far as I know champions should provide a reference implementation of their proposals. My guess is that the client of choice is usually one of [aleth, geth, parity]. Not sure if JS is a good target for reference implementations, but I agree it's great for experimentation, and this is something we can definitely help with.

As for EIP-1108, there will be an AMA for the elliptic curve cluster today, it'd be great if we could see how it fares, as there are a couple of more proposals in that cluster.

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's enough consensus on EIP-1108 that it'll most likely make it into Istanbul. It's been only requested that they update their benchmarks. I can imagine the gas costs might change slightly after that, but I think this PR is already good to go. Only one tiny nitpick :) thanks Holger

## [1.2.1] - 2019-06-03

- Added `Istanbul` HF candidate [EIP-1108](https://eips.ethereum.org/EIPS/eip-1108)
(`DRAFT`) updated `alt_bn128` precompile gas costs (see `hardforks/istanbul.json`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ... can be a separate item

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was actually meant as one sentence "added the updated precompile gas costs being a Istanbul HF candidate", can we go with the current version eventually? 😎🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah misread that

Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@holgerd77 holgerd77 merged commit edd94fc into master Jun 5, 2019
@holgerd77 holgerd77 deleted the add-draft-eip-1108-alt_bn128-gas-costs branch June 5, 2019 06:17
@holgerd77
Copy link
Member Author

Ok, just released v1.2.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants