This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the sync components (
lib/sync
). The reason for the refactor is that there was no support for back-pressure on storing blocks during sync operations. This eventually led to errors when blocks were being downloaded faster than they were being written. This PR replaces the originalFetcher
implementation with a new version that uses nodeReadable
/Writable
streams which implement back-pressure out of the box. The new stream basedFetcher
will queue downloaded blocks and pause until write operations can catch up.This PR also does a small re-factor of the
EthereumService
class. Instead of having separateHandler
s for handling incoming messages,EthereumService
is subclassed intoFastEthereumService
andLightEthereumService
which directly handle incoming messages in a newhandle()
method.