-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ecip-1066.md #526
Update ecip-1066.md #526
Conversation
Co-authored-by: Chris Ziogas <ziogas_chr@hotmail.com>
I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here. |
Add the Spiral Upgrade details to the list following the information provided in ECIP-1109. This upgrade went live on Feb 4, 2024.
|
Cool thanks 👍 |
How was eip-6049 implemented? It is not included in the 'expected action' portion and the spec is dubious + poorly defined. My understanding is this is a warning in documentation(?) to not use selfdestruct. As written, 6049 opens the door to reuse the opcode for something that a contract may not have intended when deployed. In the comments in geth it looks like we will eventually treat it as a noop after the activation block. I would recommend having it as a permanent 'noop' and not be allowed to be repurposed. ack this flag allows compatibility with eth. Its implementation or lack there of is included in this ecip update |
In core-geth |
Sounds good to me. can we squash merge this now? |
Add Spiral