-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECBP-1110: Deactivate MESS #520
Conversation
Date: 2023-12-11 07:30:17-07:00 Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
To clarify @meowsbits, MESS still exists in the client as a tool should it ever be needed again by client users, but this removes the default activation setting and adjusted the setting to "off" by default? Also for status, do we want to update 1100 with "Replaced by 1099" or something to that effect? Or keep as active, since it is still present in the client, but just not turned on by default? |
Discussion ongoing here: https://github.com/orgs/ethereumclassic/discussions/522 |
Signed-off-by: meows <b5c6@protonmail.com>
Now that we have a a block set for Mordor. Is this ECIP in a final state for review? @ethereumclassic/ecip-editors there does not appear to be any contention with this ECIP proposal and discussion has been open at: Note it appears everyone agree MESS should not exist anymore. But the discussion is now whether to deactivate/remove fully. Noting deactivate and remove could be two stage. I'm approving the PR because the deactivate of MESS is no contentious. Removal of MESS entirely is where there is some conversation to still be had on the topic. Should removal be the deemed route, this PR certainly could be updated to reflect that. I'll let you execute the merge @meowsbits in case you notice anything that needs to be cleaned up in the document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mordor activation set 10 hours ago. Discussion on the topic seems to support this change without any contention. My understanding is the MESS tool is not being removed at the moment, but its default is OFF due to the abundance of friendly/loyal hashrate that is securing the ETC network since Sept 2022.
@meowsbits can you comment on this? How should we adjust the status, if at all? |
I like your |
Signed-off-by: meows <b5c6@protonmail.com>
CI failed because Ruby's https://github.com/ethereumclassic/ECIPs/actions/runs/7463281525/job/20307577984?pr=520
|
Turn off the artificial finality mechanism ECBP-1100's MESS (Modified Exponential Scoring) in Core-Geth for Ethereum Classic.
Rendered document: https://github.com/meowsbits/ECIPs/blob/ecbp1110/_specs/ecip-1110.md
FYI I'll also be updating https://meowsbits.github.io/51-percent-docs/ this week, which provides some useful context.