Add test to verify client consistency with None topic args #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjw
force-pushed
the
filter-param-check
branch
from
c725bc1 to
d85252d
Compare
dylanjw
force-pushed
the
filter-param-check
branch
5 times, most recently
from
09e57b2 to
14dd2ec
Compare
carver
reviewed
Aug 3, 2018
tests/integration/parity/common.py
Outdated
| @@ -97,6 +97,10 @@ def test_eth_getTransactionReceipt_unmined(self, web3, unlocked_account): | |||
| assert receipt is not None | |||
| assert receipt['blockHash'] is None | |||
|
|
|||
| def test_eth_getLogs_with_logs_none_topic_args(self, web3): | |||
| with pytest.raises(AssertionError): | |||
There was a problem hiding this comment.
In all the other places I can think of, we do @pytest.mark.xfail instead of this approach. Nothing wrong with this that I can think of, it's just nice to have a little more stylistic consistency.
carver
approved these changes
Aug 3, 2018
dylanjw
force-pushed
the
filter-param-check
branch
from
14dd2ec to
91b64f7
Compare
dylanjw
force-pushed
the
filter-param-check
branch
from
91b64f7 to
79b2970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Want to verify client handling of None topic parameters yields consistent match results.
How was it fixed?
Extended the getLogs test to try retrieving log matches using None values for topics.
Cute Animal Picture