Fix ABI encoding of arrays of strings and bytes #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
changed the title
|
pytest 3.3.0 was breaking our tests, due to pytest-dev/pytest#2957 |
pipermerriam
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Only in v4:
contract.encodeABIfails to encode a byte-array with:It was trying to convert an array of hex strings into bytes all at once.
This conversion to bytes only happens in contract ABI encoding, because
encode_abiexpects byte arguments, and the other places that do this encoding (like middleware before sending to a client) expect hex-encoded arguments.How was it fixed?
Check that conversion from hex to bytes only happens at the basic type level, not the array level.
Cute Animal Picture