tests/beacon: use fixture for user_defined_request_timeout tests #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following warning: tests/beacon/test_async_beacon.py::test_async_beacon_user_request_timeout /home/lukas/Documents/git/web3.py/venv/lib64/python3.13/site-packages/aiohttp/client.py:417: ResourceWarning: Unclosed client session <aiohttp.client.ClientSession object at 0x7f9562d34a50> The change to the syncronous beacon class test is just to make it uniform Signed-off-by: Lukas Rusak <lorusak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Running
pytest -rP tests/beacon/test_async_beacon.pymakes the following warning:The change to the synchronous beacon class test is just to make it uniform
How was it fixed?
By using the fixture so that the closure runs and cleans up the aiohttp.client.ClientSession after the test
Todo: