Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V6] Fix process_log for HexStr inputs #3292

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Mar 18, 2024

What was wrong?

Related to Issue #3286

Realized the topics and data values had not been explicitly converted to bytes. The initial fix I made was to convert the log topics to a HexStr but since bytes are needed later on, it made sense to just ensure everything is coerced to bytes before handling them.

How was it fixed?

Explicit type coercion of entry topics and data values.

Todo:

Cute Animal Picture

Screen Shot 2024-03-18 at 12 19 02 PM

@reedsa reedsa changed the title process_log explicit type coercion for entry topics and data values Fix process_log for HexStr inputs Mar 18, 2024
reedsa added a commit to reedsa/web3.py that referenced this pull request Mar 18, 2024
@reedsa reedsa changed the base branch from main to v6 March 18, 2024 18:21
@reedsa reedsa changed the title Fix process_log for HexStr inputs [V6] Fix process_log for HexStr inputs Mar 18, 2024
reedsa added a commit to reedsa/web3.py that referenced this pull request Mar 18, 2024
@reedsa reedsa force-pushed the event-data-coercion branch from ceaa29a to 88a3f88 Compare March 18, 2024 18:31
reedsa added 2 commits March 18, 2024 12:43
@reedsa reedsa force-pushed the event-data-coercion branch from 88a3f88 to 443b79b Compare March 18, 2024 18:43
@reedsa reedsa marked this pull request as ready for review March 18, 2024 18:54
@reedsa reedsa requested review from fselmo, pacrob and kclowes March 18, 2024 18:54
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@reedsa reedsa merged commit 18240c2 into ethereum:v6 Mar 18, 2024
99 checks passed
reedsa added a commit to reedsa/web3.py that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants