[WIP] Async filters feature branch #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
reviewed
Jul 27, 2022
fselmo
previously approved these changes
Jul 27, 2022
There was a problem hiding this comment.
I left a comment on the TODOs. We can remove those. I'd like to add testing around the logs as well. Did you run into any issues porting those from sync to async?
Disregard that, those were eth_getLogs tests I was seeing, not eth_getFilterLogs. Taking out these TODOs, This looks good to me 👍
|
Oops... I guess if this is the base for the feature branch I will un-approve so we can approve different PRs into here and approve the whole thing later. |
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Aug 31, 2022
* async filters eth module
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Sep 8, 2022
* async filters eth module
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Sep 12, 2022
* async filters eth module
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Oct 7, 2022
* async filters eth module
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Dec 8, 2022
* async filters eth module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Filters need async, this branch will collect related changes.
Related to Issue #2573
Todo:
Cute Animal Picture