Cleaned Up Async ENS #2526
Closed
Cleaned Up Async ENS #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change ``ens.main`` to ``ens.ens`` * Reorganize ENS, AsyncENS, and BaseENS into separate modules * Added AsyncENSFactory to handle async creation of AsyncENS * Added async ENS tests * Update docs * newsfragment
* Add some missing awaits * Add a lot more testing around AsyncENS. We can think about splitting AsyncEthereumTesterProvider tests off into their own CI job if they get too big but we should provide ample testing around the async implementation to make sure it's all wired up correctly. * Cleanup for better readability and consistency across ENS and AsyncENS * Keep async_ens_setup as module scope with a module-scoped event_loop fixture and add a module-scoped async_w3 for ens module * Fix some minor warnings with optionals where ``None`` is being passed in * nit: Since we are adding so many new lines, match code style to ideal rest of library for consistency. Trailing commas with new arguments allow for a cleaner git blame / git history since the next bit of code added would only touch the new line that is created, etc. (``black`` formatting PRs are coming in now though so this wasn't very important after the first commit that was squashed here).
fselmo
force-pushed
the
cleanup-async-ens
branch
from
8e3341e to
9154ded
Compare
|
just kidding... we effectively cleaned up #2501 with a force push after cherry picking only the non-merge commits and rebasing locally against Closing this so the conversation can just stay in one place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked and squashed relevant commits, updated commit messages from PR #2501. Merge commits can't be squashed easily so this is just the easiest way to clean up the commit history. Refer to that PR for all details and conversations around the changes.
Use
git diff cleanup-async-ens dbfreem/feature/ens_asyncifyto see there are minor re-organizing differences between these two PRs / branchescloses #2501