Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract.call() block_identifier default change #2335

Closed
wants to merge 1 commit into from

Conversation

newtectonics
Copy link
Contributor

Changed default block_identifier in contract.call() to None.
Changed parse_block_identifier to use web3.eth.defaultBlock if None is passed in

What was wrong?

#2334

How was it fixed?

changed block_identifier default to None in contract.call
changed parse_block_identifier to parse None to web3.eth.default_block

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Changed default block_identifier in contract.call() to None.
Changed parse_block_identifier to use web3.eth.defaultBlock if None is passed in
@newtectonics newtectonics changed the title contract block_identifier default change contract.call() block_identifier default change Feb 3, 2022
@kclowes
Copy link
Collaborator

kclowes commented Feb 3, 2022

Thanks for the PR! This looks like a good change to me, but we'll need to wait until v6 to pull it in since it's breaking like you mentioned in the issue. We're planning on cutting our v6 branch soon, so will add this to be pulled in then. It will need a test before merging. If you have time to add one that would be great, otherwise I should be able to get to it soon:tm:.

@kclowes kclowes mentioned this pull request Feb 3, 2022
22 tasks
@kclowes kclowes added the v6 Breaking changes that were considered for v6 (old) label Feb 4, 2022
@kclowes kclowes mentioned this pull request Jan 12, 2023
1 task
@kclowes
Copy link
Collaborator

kclowes commented Jan 12, 2023

Sorry @newtectonics that I wasn't able to keep this PR. I opened one at #2777 that has your initial commit, and I added some tests and things after that. You should still get credit on that initial commit.

Closing in favor of #2777.

@kclowes kclowes closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v6 Breaking changes that were considered for v6 (old)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants