Fix for HypothesisDeprecationWarning in tox run test CircleCI #1729 #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved fixtures into test_contract_topic_filter.py Both of these were to fix HypothesisDeprecationWarning while running test
…_topic_filters.py
kclowes
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
HypothesisDeprecationWarning in tox run test CircleCI
Related to Issue # 1729
How was it fixed?
I took some of the suggestions made by @kclows in the #1729 on how to fix this.
Added conftest.py to test/core/utilities and moved web3 fixture to it
Moved fixtures into test_contract_topic_filter.py
Both of these were to fix HypothesisDeprecationWarning while running test
Todo
I only ran this against tox py38-core since I don't currently have all the interpreters that tox is looking for on my machine
Hope this helps!!