Eth to method 4 #1741
Merged
Eth to method 4 #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
eth-to-method-4
branch
2 times, most recently
from
9c1f257 to
b6e8228
Compare
kclowes
force-pushed
the
eth-to-method-4
branch
from
9772b8a to
179199a
Compare
kclowes
force-pushed
the
eth-to-method-4
branch
from
179199a to
921dec2
Compare
wolovim
reviewed
Sep 17, 2020
web3/_utils/method_formatters.py
Outdated
| @@ -360,7 +362,7 @@ def apply_list_to_array_formatter(formatter: Any) -> Callable[..., Any]: | |||
| RPC.eth_getUncleCountByBlockNumber: apply_formatter_at_index(block_number_formatter, 0), | |||
| RPC.eth_getUncleByBlockNumberAndIndex: compose( | |||
| apply_formatter_at_index(block_number_formatter, 0), | |||
| apply_formatter_at_index(integer_to_hex, 1), | |||
| apply_formatter_at_index(block_number_formatter, 1), | |||
There was a problem hiding this comment.
This has a smell. The formatter is being applied to the index, right?
| params: Tuple[BlockIdentifier, Union[HexStr, int]] | ||
| ) -> NoReturn: | ||
| block_identifier = params[0] | ||
| uncle_index = to_integer_if_hex(params[1]) |
There was a problem hiding this comment.
(Carrying on from the last comment) I do think this explicit pattern is easier to reason about than the block_number_formatter. What do you think about renaming block_number_formatter to to_hex_if_integer, since this formatter has bled outside of just block number formatting? (Okay if not in this PR.)
There was a problem hiding this comment.
Yep, agreed. I had a duplicate method in the original PR, so I'll add that here, and then add an issue to remove the duplicated method in a separate PR.
EDIT: See #1745
wolovim
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The Eth module needs to be moved to use Method. Part 4 includes changes to:
Related to Issue #1568
How was it fixed?
Updated eth.py to use Method for the above methods
Todo:
Cute Animal Picture