Move txpool to geth namespace #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
relocate-txpool
branch
from
4419e55 to
8669f81
Compare
njgheorghita
force-pushed
the
relocate-txpool
branch
from
8669f81 to
08ab721
Compare
kclowes
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
LGTM! 🚢 unless @pipermerriam has any feedback?
EDIT: wait a minute... don't we need to change this to web3.geth.txpool?
|
@kclowes Good catch! Also forgot to update the docs 😬 |
njgheorghita
force-pushed
the
relocate-txpool
branch
from
e90fb4f to
5285718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Since only geth supports
txpool_*jsonrpc endpoints, and they are also not defined in EIP 1474,web3.txpoolwas moved toweb3.geth.txpoolCute Animal Picture