Drop repeated RPC endpoints (V5 beta) #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
drop-repeated-rpc-endpoints
branch
2 times, most recently
from
f08ca84 to
9faafa0
Compare
njgheorghita
force-pushed
the
drop-repeated-rpc-endpoints
branch
from
9faafa0 to
5e076c8
Compare
njgheorghita
changed the title
pipermerriam
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Duplicate web3 endpoints for the same RPC endpoint
Fixes #1026
How was it fixed?
Removed...
web3.mining.hashratewhich was a duplicate forweb3.eth.hashrate(RPC endpoint =eth_hashrate)web3.version.networkwhich was a duplicate forweb3.net.version(RPC endpoint =net_version)These two were the only obvious conflicts I noticed
Cute Animal Picture