Freebsd support: cleanup and tox fix #1156
Conversation
docs/README-freebsd.md
Outdated
| @@ -44,7 +61,13 @@ BROKEN (build crashes on FreeBSD 11.2) | |||
| ``` | |||
|
|
|||
| ``` | |||
| cd web3.py | |||
| tox | |||
There was a problem hiding this comment.
Maybe tox -e py36-core and others, since it's unreasonable to run the whole suite at once right now.
There was a problem hiding this comment.
Well, right... I've just followed "It is important to understand that each Pull Request must pass the full test suite as part of the CI check, hence it is often convenient to have tox installed locally as well." rule from https://py-evm.readthedocs.io/en/latest/contributing.html. So do you want me to update that?
There was a problem hiding this comment.
To clarify, I'm suggesting something like:
tox -e py36-core
tox -e py36-ens
etc
Hm, I don't disagree with anything in that statement in the docs (also it's in py-evm docs instead of web3.py). How are you suggesting the text should be updated?
There was a problem hiding this comment.
I've messes up py-evm with web3.py again, sorry... Yes, your suggestion looks ok, I'll update pull request.
|
fixed for good here: #1159 |
|
Can you rebase on master @rayrapetyan ? |
(cherry picked from commit 73a869b)
|
Not sure this is in desired state, please check. Thanks. |
|
Thanks! |
What was wrong?
How was it fixed?