Block Identifier default change #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed default block_identifier in contract.call() to None. Changed parse_block_identifier to use web3.eth.defaultBlock if None is passed in
kclowes
force-pushed
the
credmark/master
branch
from
31b4d06 to
cc5eb7f
Compare
1 task
|
Thanks for the contribution @newtectonics! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what happened, but I can't add to the original PR, which can be found at #2335.
Here is the PR description from there:
Changed default block_identifier in contract.call() to None.
Changed parse_block_identifier to use web3.eth.defaultBlock if None is passed in
What was wrong?
#2334
How was it fixed?
changed block_identifier default to None in contract.call
changed parse_block_identifier to parse None to web3.eth.default_block
Todo:
Cute Animal Picture