Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snakecase clientVersion #2686

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Snakecase clientVersion #2686

merged 3 commits into from
Oct 27, 2022

Conversation

linda-le1
Copy link
Contributor

@linda-le1 linda-le1 commented Oct 20, 2022 •
edited
Loading

What was wrong?

Inherited javascript syntax. This PR does not include a deprecation step, intended for v6.
Related to #2598

How was it fixed?

Changed clientVersion to client_version where needed

Todo:

Cute Animal Picture

shiba

@linda-le1 linda-le1 marked this pull request as ready for review October 20, 2022 10:56
kclowes
kclowes reviewed Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💪 🎉 Looks like there is a quick lint check that needs to be addressed, and a newsfragment is missing. I think most of us have black running on save, which should take care of most lint errors.

The newsfragment will be a new file called newsfragments/2686.breaking.rst and can just contain a sentence with what changed.

Thank you!

tests/core/web3-module/test_clientVersion.py
@@ -1,2 +0,0 @@
def test_web3_clientVersion(w3):
assert w3.clientVersion.startswith("EthereumTester/")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have just missed it, but it looks like this file got deleted instead of moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Just forgot to push up my latest branch where I renamed this file.

@linda-le1 linda-le1 force-pushed the snakecase-clientversion branch from 6a120cd to c6abd37 Compare October 20, 2022 16:07
@linda-le1
Copy link
Contributor Author

@kclowes question on the linter: I ran black over the files in my PR and nothing seemed to change. Did I maybe miss something?

@kclowes
Copy link
Collaborator

kclowes commented Oct 20, 2022

Ah, sorry. black doesn't do anything with strings. You can either add a #noqa: E501 at the end of the line, or split the string into two lines. Then we should be good to go!

@linda-le1 linda-le1 requested a review from kclowes October 21, 2022 22:55
kclowes
kclowes approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@kclowes kclowes merged commit 1604895 into ethereum:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linda-le1 @kclowes