Snakecase clientVersion

Author: linda-le1

docs/middleware.rst

@@ -389,7 +389,7 @@ The easiest way to connect to a default ``geth --dev`` instance which loads the
     >>> from web3.auto.gethdev import w3
 
     # confirm that the connection succeeded
-    >>> w3.clientVersion
+    >>> w3.client_version
     'Geth/v1.7.3-stable-4bb3c89d/linux-amd64/go1.9'
 
 This example connects to a local ``geth --dev`` instance on Linux with a
@@ -408,7 +408,7 @@ unique IPC location and loads the middleware:
     >>> w3.middleware_onion.inject(geth_poa_middleware, layer=0)
 
     # confirm that the connection succeeded
-    >>> w3.clientVersion
+    >>> w3.client_version
     'Geth/v1.7.3-stable-4bb3c89d/linux-amd64/go1.9'
 
 Why is ``geth_poa_middleware`` necessary?

docs/providers.rst

@@ -134,10 +134,10 @@ For example, the following retrieves the client enode endpoint for both geth and
 
     connected = w3.is_connected()
 
-    if connected and w3.clientVersion.startswith('Parity'):
+    if connected and w3.client_version.startswith('Parity'):
         enode = w3.parity.enode
 
-    elif connected and w3.clientVersion.startswith('Geth'):
+    elif connected and w3.client_version.startswith('Geth'):
         enode = w3.geth.admin.node_info['enode']
 
     else:

docs/web3.main.rst

@@ -37,15 +37,15 @@ Attributes
        >>> web3.api
        "4.7.0"
 
-.. py:attribute:: Web3.clientVersion
+.. py:attribute:: Web3.client_version
 
     * Delegates to ``web3_clientVersion`` RPC Method
 
     Returns the current client version.
 
     .. code-block:: python
 
-       >>> web3.clientVersion
+       >>> web3.client_version
        'Geth/v1.4.11-stable-fed692f6/darwin/go1.7'
 
 

newsfragments/2686.doc.rst

@@ -0,0 +1 @@
+Snakecase the clientVersion method

tests/core/version-module/test_version_module.py

@@ -55,4 +55,4 @@ def test_legacy_version_deprecation(blocking_w3):
 async def test_async_blocking_version(async_w3, blocking_w3):
     assert async_w3.async_version.api == blocking_w3.api
 
-    assert await async_w3.async_version.node == blocking_w3.clientVersion
+    assert await async_w3.async_version.node == blocking_w3.client_version

tests/core/web3-module/test_clientVersion.py

@@ -0,0 +1,2 @@
+def test_web3_client_version(w3):
+    assert w3.client_version.startswith("EthereumTester/")

tests/core/web3-module/test_client_version.py

@@ -29,7 +29,7 @@
 
 
 class GoEthereumTest(Web3ModuleTest):
-    def _check_web3_clientVersion(self, client_version):
+    def _check_web3_client_version(self, client_version):
         assert client_version.startswith("Geth/")
 
 

tests/integration/go_ethereum/common.py

@@ -251,7 +251,7 @@ def funded_account_for_raw_txn(w3):
 
 
 class TestEthereumTesterWeb3Module(Web3ModuleTest):
-    def _check_web3_clientVersion(self, client_version):
+    def _check_web3_client_version(self, client_version):
         assert client_version.startswith("EthereumTester/")
 
 

tests/integration/test_ethereum_tester.py

@@ -25,11 +25,11 @@
 
 
 class Web3ModuleTest:
-    def test_web3_clientVersion(self, w3: Web3) -> None:
-        client_version = w3.clientVersion
-        self._check_web3_clientVersion(client_version)
+    def test_web3_client_version(self, w3: Web3) -> None:
+        client_version = w3.client_version
+        self._check_web3_client_version(client_version)
 
-    def _check_web3_clientVersion(self, client_version: str) -> NoReturn:
+    def _check_web3_client_version(self, client_version: str) -> NoReturn:
         raise NotImplementedError("Must be implemented by subclasses")
 
     # Contract that calculated test values can be found at

web3/_utils/module_testing/web3_module.py

@@ -274,7 +274,7 @@ def provider(self, provider: Union[BaseProvider, AsyncBaseProvider]) -> None:
         self.manager.provider = provider
 
     @property
-    def clientVersion(self) -> str:
+    def client_version(self) -> str:
         return self.manager.request_blocking(RPC.web3_clientVersion, [])
 
     @property

web3/main.py

@@ -60,7 +60,7 @@ def api(self) -> NoReturn:
     @property
     def node(self) -> NoReturn:
         raise DeprecationWarning(
-            "This method has been deprecated ... Please use web3.clientVersion instead."
+            "This method has been deprecated ... Please use web3.client_version instead."
         )
 
     @property