This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Weaken criterion for attestation inclusion #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NIC619
approved these changes
Mar 17, 2019
| raise ValidationError( | ||
| "Attestation slot plus `SLOTS_PER_EPOCH` is too low; " | ||
| "must exceed the current state:\n" | ||
| "Attestation slot plus `SLOTS_PER_EPOCH` is too low\n" |
There was a problem hiding this comment.
Should this be made an f-string and the \t in the beginning of the next line removed?
There was a problem hiding this comment.
I think it's okay, \n (escape) is fine in the normal string.
\t is a readability improvement here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #411
How was it fixed?
Change
to
Cute Animal Picture