Fix InvalidGossipMessage messages and co-attest

[hwwhww]

What was wrong?

Thanks to @ChihChengLiang for post feedback on #1311.

How was it fixed?

To-Do

• Clean up commit history

• Add entry to the release notes

Cute Animal Picture

[ChihChengLiang]

say we have

class A(Exception):
    ...

class B(Exception):
    ...

if we do

try:
    raise A("Some A reason")
except A as a:
    raise B("Some B reason") from A

we get

__main__.A

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "foo.py", line 12, in <module>
    raise B("Some B reason") from A
__main__.B: Some B reason

if we do

try:
    raise A("Some A reason")
except A as a:
    raise B("Some B reason", a)

We get

Traceback (most recent call last):
  File "foo.py", line 10, in <module>
    raise A("Some A reason")
__main__.A: Some A reason

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "foo.py", line 12, in <module>
    raise B("Some B reason", a)
__main__.B: ('Some B reason', A('Some A reason'))

If we want to keep the message from the ValidationError, we can do

Suggested change

	f"Failed to validate aggregate_and_proof={aggregate_and_proof}, error={str(error)}",
	f"Failed to validate aggregate_and_proof={aggregate_and_proof}, error

[hwwhww]

Yeah but I just want to make InvalidGossipMessage only in DEBUG log instead of shouting loudly. InvalidGossipMessage will be caught in topic validator:

trinity/trinity/protocol/bcc_libp2p/topic_validators.py

Lines 63 to 65 in cffd17f

	except InvalidGossipMessage as error:
	logger.debug("%s", str(error))
	return False

[ChihChengLiang]

Ah, I see. Note that we can still get the full message in the log with the B("Some B reason", a) style. But both ways look good.

def foo():
    try:
        raise A("Some A reason")
    except A as a:
        raise B("Some B reason", a)

import logging

try:
    foo()
except B as b:
    logging.getLogger("__main__").warning(b)
    # ('Some B reason', A('Some A reason'))