fix: improve light client testing coverage #1636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There was a problem with our hive beacon test fixtures, but those have been updated in
portal-spec-tests
. It wasn't a problem with our decoding / encoding logic, just the actual fixture data. But these are some improvements to our testing that at the very least increase our coverage (to both capella & deneb types), and remove some redundant test-fixtures (the test fixtures that were inside/test-assets/portalnet/content/beacon/*
are available inportal-spec-tests
)How was it fixed?
portal-spec-tests
submoduleTo-Do