Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve light client testing coverage #1636

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Jan 14, 2025

What was wrong?

There was a problem with our hive beacon test fixtures, but those have been updated in portal-spec-tests. It wasn't a problem with our decoding / encoding logic, just the actual fixture data. But these are some improvements to our testing that at the very least increase our coverage (to both capella & deneb types), and remove some redundant test-fixtures (the test fixtures that were inside /test-assets/portalnet/content/beacon/* are available in portal-spec-tests)

How was it fixed?

  • removed redundant test fixtures
  • added tests for both capella and deneb types
  • updated portal-spec-tests submodule

To-Do

@njgheorghita njgheorghita requested a review from ogenev January 14, 2025 17:04
@njgheorghita njgheorghita force-pushed the decoding-deneb-bug branch 3 times, most recently from 4e35101 to 991061b Compare January 14, 2025 20:18
@njgheorghita njgheorghita changed the title fix: broken deneb decoding bug fix: improve light client testing coverage Jan 14, 2025
@njgheorghita njgheorghita marked this pull request as ready for review January 14, 2025 20:32
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good and much cleaner

@njgheorghita njgheorghita merged commit 888e8e3 into ethereum:master Jan 14, 2025
11 checks passed
@njgheorghita njgheorghita deleted the decoding-deneb-bug branch January 14, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants