Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move crate trin-execution to bin/trin-execution #1635

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Jan 14, 2025

What was wrong?

binary crates should be in the bin folder. I said I was going to make this PR here #1624 and #1621

How was it fixed?

moving the crate

in the future we can crate out some parts of trin-execution as well, but for now this move is good enough

@KolbyML KolbyML force-pushed the move-trin-execution branch from 7757ef9 to ad967db Compare January 14, 2025 14:23
@KolbyML KolbyML self-assigned this Jan 14, 2025
Copy link
Collaborator

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KolbyML KolbyML force-pushed the move-trin-execution branch 2 times, most recently from 083f9de to d54cac8 Compare January 14, 2025 17:09
@KolbyML KolbyML force-pushed the move-trin-execution branch from d54cac8 to 6bc6ca5 Compare January 14, 2025 17:13
@KolbyML KolbyML merged commit add9be3 into ethereum:master Jan 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants