Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionTests Update: ttWrongRLP #968

Merged
merged 5 commits into from
Oct 22, 2021
Merged

TransactionTests Update: ttWrongRLP #968

merged 5 commits into from
Oct 22, 2021

Conversation

marioevz
Copy link
Member

This PR fixes the test cases in TransactionTests/ttWrongRLP, which all use the Copier.json format.

There are outstanding issues with the test cases:

  • EVM returns exit code != 0 due to malformed RLP, and retesteth doesn't know how to handle this response yet:
    RLPExtraRandomByteAtTheEnd
    RLPHeaderSizeOverflowInt32
    RLPListLengthWithFirstZeros
    TRANSCT_HeaderLargerThanRLP_0
    TRANSCT__RandomByteAtRLP_0-9
    TRANSCT__RandomByteAtTheEnd
    TRANSCT__ZeroByteAtRLP_0-9
    aMaliciousRLP
  • Differing hash calculated by retesteth and evm results in "Client didn't reject transaction":
    RLPElementIsListWhenItShouldntBe2
    RLPElementIsListWhenItShouldntBe
    TRANSCT_data_GivenAsList
    TRANSCT_gasLimit_GivenAsList
    TRANSCT_rvalue_GivenAsList
    TRANSCT_svalue_GivenAsList
    TRANSCT_to_GivenAsList
  • Tests attempt to send malformed hex string where the characters contain values outside of valid set [0-9, a-f]:
    RLPWrongAddress
    RLPWrongData
    TRANSCT__WrongCharAtRLP_*
  • Test case where evm parses two different transactions from a single RLP:
    TRANSCT__ZeroByteAtTheEnd

Commits used for testing:
Retesteth: ethereum/retesteth@3cdfde3
Geth: holiman/go-ethereum@9d377a9

@marioevz
Copy link
Member Author

I removed the failing tests' fillers, which will be incorporated in a new PR.

Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, that must have been a lot of manual work...

@winsvega winsvega merged commit d950bf7 into develop Oct 22, 2021
@winsvega winsvega deleted the txUpdateWrongRLP branch October 22, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants