TransactionTests Update: ttWrongRLP #968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the test cases in TransactionTests/ttWrongRLP, which all use the Copier.json format.
There are outstanding issues with the test cases:
RLPExtraRandomByteAtTheEnd
RLPHeaderSizeOverflowInt32
RLPListLengthWithFirstZeros
TRANSCT_HeaderLargerThanRLP_0
TRANSCT__RandomByteAtRLP_0-9
TRANSCT__RandomByteAtTheEnd
TRANSCT__ZeroByteAtRLP_0-9
aMaliciousRLP
RLPElementIsListWhenItShouldntBe2
RLPElementIsListWhenItShouldntBe
TRANSCT_data_GivenAsList
TRANSCT_gasLimit_GivenAsList
TRANSCT_rvalue_GivenAsList
TRANSCT_svalue_GivenAsList
TRANSCT_to_GivenAsList
RLPWrongAddress
RLPWrongData
TRANSCT__WrongCharAtRLP_*
TRANSCT__ZeroByteAtTheEnd
Commits used for testing:
Retesteth: ethereum/retesteth@3cdfde3
Geth: holiman/go-ethereum@9d377a9