Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests for ttSignature #967

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Fix failing tests for ttSignature #967

merged 2 commits into from
Oct 19, 2021

Conversation

marioevz
Copy link
Member

This PR fixes the following test cases for ttSignature:

  • EmptyTransaction: Changed the filler to have empty values for all fields. Test case failing with: "invalid transaction v, r, s values"
  • TransactionWithTooFewRLPElements / TransactionWithTooManyRLPElements: Changed to "Copier" format and added the txbytes RLP directly. Test cases correctly failing with "rlp: too few elements" and "rlp: input list has too many elements" respectively, but retesteth is currently not recognizing the exceptions.

winsvega
winsvega approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this are good tests. too bad t9n does not test the geth logic.
I suggest not to focus on this scenarios just yet. there is bcForgedTest folder with this kind of tests that are being fed to client as a block rlp. which can be executed on hive.
lets work on that next.

@winsvega winsvega merged commit c648325 into develop Oct 19, 2021
@winsvega winsvega deleted the txUpdateSignatureFix branch October 19, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @winsvega