Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Cases with Explicit Chain ID to ttVValue #966

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Conversation

marioevz
Copy link
Member

This PR adds 8 test cases to the TransactionTests/ttVValue test suite where the "chainId" field is explicitly set:

  • Two positive test cases where CHAIN_ID == 1, and V == {0,1} + CHAIN_ID * 2 + 35
  • Two negative test cases where CHAIN_ID == 0, and V == {0,1} + CHAIN_ID * 2 + 35
  • Two negative test cases where CHAIN_ID == 1, and V != {0,1} + CHAIN_ID * 2 + 35
  • Two negative test cases where CHAIN_ID == 1, and V == {0,1} + CHAIN_ID * 2 + 35, but V has leading zeros

"nonce" : "3",
"to" : "b94f5374fce5edbc8e2a8697c15331677e6ebf0b",
"value" : "10",
"chainId" : "1",
Copy link
Collaborator

@winsvega winsvega Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field does not affect anything. (for legacy type transaction)
retesteth allows it because besu return transaction with this field for all transaction types.

@winsvega winsvega merged commit fbff6fe into develop Oct 22, 2021
@winsvega winsvega deleted the txVValueChainID branch October 22, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants