TransactionTests Update: ttRSValue #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
reviewed
Oct 12, 2021
src/TransactionTestsFiller/ttRSValue/TransactionWithSvaluePrefixed00Filler.json
Show resolved
Hide resolved
| ], | ||
| "TransactionWithSvalue1" : | ||
| { | ||
| "expectException" : |
There was a problem hiding this comment.
is it a github bug or ident here is different to the one with transaction?
There was a problem hiding this comment.
The indent was incorrect in the original file, I tried to make indentation consistent in all files.
src/TransactionTestsFiller/ttRSValue/TransactionWithRvaluePrefixed00Filler.json
Show resolved
Hide resolved
| { | ||
| "expectException" : | ||
| { | ||
| "<=EIP150": "InvalidVRS", |
There was a problem hiding this comment.
oh, I forgot I actully support <= in network translation
There was a problem hiding this comment.
here it should reject I think not with invalid chain id but with prefixed 00, as the v value limitations. need to check with the v value cap.
There was a problem hiding this comment.
Changed the expected to LeadingZerosV, and changed the V value to bigint.
Let me know if this is ok.
winsvega
reviewed
Oct 15, 2021
| @@ -14,9 +13,9 @@ | |||
| "nonce" : "0", | |||
| "to" : "095e7baea6a6c7c4c2dfeb977efac326af552d87", | |||
| "value" : "11", | |||
| "v" : "27", | |||
| "v" : "28", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains updated TransactionTests for category ttRSValue.