TransactionTests Update: ttNonce #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
requested changes
Oct 12, 2021
| "data" : "", | ||
| "gasLimit" : "21000", | ||
| "gasPrice" : "1", | ||
| "nonce" : "115792089237316195423570985008687907853269984665640564039457584007913129639935", |
There was a problem hiding this comment.
this is not 18446744073709551617 (64 + 1)
There was a problem hiding this comment.
Fixed the values in latest commit.
| "data" : "", | ||
| "gasLimit" : "21000", | ||
| "gasPrice" : "1", | ||
| "nonce" : "18446744073709551615", |
There was a problem hiding this comment.
this is 64 - 1, need to name the test accordingly
and where the exact bound ?
I think it because there was a discussion on nonce cap.
There was a problem hiding this comment.
It fails on 2 ** 64, so I changed the tests to match the correct values and added another test case in latest commit.
| { | ||
| "expectException" : | ||
| { | ||
| ">=Frontier": "NonceTooLong" |
There was a problem hiding this comment.
so here it did fail on >256 ?
There was a problem hiding this comment.
It correctly fails on 2**64, I updated all tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains updated TransactionTests for category ttNonce.