-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransactionTests Update: ttEIP2028 #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
"EIP158" : "TR_IntrinsicGas", | ||
"Byzantium" : "TR_IntrinsicGas", | ||
"Constantinople" : "TR_IntrinsicGas", | ||
"ConstantinopleFix" : "TR_IntrinsicGas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>= Istanbul
not explicit that we don't mark validity here, but ok. just need to remember that tests are against all forks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this in the latest commit.
"Byzantium" : "TR_IntrinsicGas", | ||
"Constantinople" : "TR_IntrinsicGas", | ||
"ConstantinopleFix" : "TR_IntrinsicGas", | ||
">=Istanbul" : "TR_IntrinsicGas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then you can mark >= Frontier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this in the latest commit.
Contains updated TransactionTests for category ttEIP2028.