Add more RLP invalid tests for non-optimal lengths. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-existing tests bytesShouldBeSingleByteXX cover the case in which a single byte below 128 is erroneously encoded with a one-byte (i.e. short) length. The new proposed tests cover the following additional cases: - A multi-byte (i.e. long) length has leading zeros, for byte arrays or for lists. - A multi-byte length is used where a short length suffices, for byte arrays and for lists.
winsvega
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-existing tests bytesShouldBeSingleByteXX cover the case in which a
single byte below 128 is erroneously encoded with a one-byte (i.e. short)
length.
The new proposed tests cover the following additional cases:
lists.
for lists.
I tried running the scripts that check the well-formedness of the tests, but ran into problems and created Issue #611. Also, I'm not sure which other requirements should be fulfilled in order for these new tests to be accepted.
To provide some assurance, the new proposed tests are rejected by the formally verified RLP decoder available at https://github.com/acl2/acl2/blob/master/books/kestrel/ethereum/rlp/decoding-executable.lisp.