Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transStorage): First version #1220

Merged
merged 10 commits into from
Jun 1, 2023
Merged

feat(transStorage): First version #1220

merged 10 commits into from
Jun 1, 2023

Conversation

qbzzt
Copy link
Collaborator

@qbzzt qbzzt commented May 21, 2023

Replacing #1217, which got messed up somehow.

This includes both transStorageOK for successful uses of trans and transStorageReset for failures caused by reverts of various kinds.

@qbzzt qbzzt changed the title feat(transStorageOK): First version feat(transStorage): First version May 24, 2023
@winsvega
Copy link
Collaborator

winsvega commented May 31, 2023

Error: Test /home/travis/build/ethereum/tests/EIPTests/StateTests/stEIP1153-transientStorage/transStorageOK.json is outdated. Filler hash is different! ('f505' != '8d10')  

Test Case "stEIP1153-transientStorage": (16 of 17)
Error: Tests are not generated (forgot --filltests?): 
 /home/travis/build/ethereum/tests/src/EIPTestsFiller/StateTests/stEIP1153-transientStorage/transStorageResetFiller.yml => /home/travis/build/ethereum/tests/EIPTests/BlockchainTests/StateTests/stEIP1153-transientStorage/transStorageReset.json
 /home/travis/build/ethereum/tests/src/EIPTestsFiller/StateTests/stEIP1153-transientStorage/transStorageOKFiller.yml => /home/travis/build/ethereum/tests/EIPTests/BlockchainTests/StateTests/stEIP1153-transientStorage/transStorageOK.json

@holgerd77
Copy link
Contributor

Quick question: are these additional tests to https://github.com/ethereum/tests/tree/develop/EIPTests/BlockchainTests/bcEIP1153-transientStorage or will they replace the former?

And are these current tests in EIPTests up to date with the latest specs?

@winsvega
Copy link
Collaborator

winsvega commented Jun 1, 2023

if you ask about previous tests for eip1153 this are additional to them.
if you ask about bc version - all bc tests are copy of state tests in its bc form for hive test runner.
the state test version is used by custom client test runners.

the tests filled using this geth commit
evm version 1.11.0-unstable-efdc1274-20230505

@qbzzt whats the branch?

// has the storage.

// First invocation, called by 0xCCCCC...CCCC
if iszero(tload_temp(0)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you rely on tload here which is being tested. if tload is not working properly it can return zero on the second call, and you will think it is the first invocation when actually it is not

@winsvega winsvega merged commit be07adc into develop Jun 1, 2023
@winsvega winsvega deleted the qbzzt/230520-eip-1153 branch June 1, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants