-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transStorage): First version #1220
Conversation
|
…ests into qbzzt/230520-eip-1153
Quick question: are these additional tests to https://github.com/ethereum/tests/tree/develop/EIPTests/BlockchainTests/bcEIP1153-transientStorage or will they replace the former? And are these current tests in |
if you ask about previous tests for eip1153 this are additional to them. the tests filled using this geth commit @qbzzt whats the branch? |
// has the storage. | ||
|
||
// First invocation, called by 0xCCCCC...CCCC | ||
if iszero(tload_temp(0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you rely on tload here which is being tested. if tload is not working properly it can return zero on the second call, and you will think it is the first invocation when actually it is not
Replacing #1217, which got messed up somehow.
This includes both
transStorageOK
for successful uses of trans andtransStorageReset
for failures caused by reverts of various kinds.