-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The SignedBLSToExecutionChange
JSON file schema
#312
Comments
The hex values will need to be prefixed with The metadata fields may or may not be accepted by the consenus nodes, depending on if they are being strict on the JSON they accept. Would need to be checked with each of them individually to be sure. |
The format generally looks good to me. I haven't been following the deposit specs intimately, though. I agree with @mcdee that the lack of FYI there's a typo in the schema: |
The format looks ok. Although I would prefer if we had "0x" prefixes matching the API definition (https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/submitPoolBLSToExecutionChange).
In Teku we are lenient as long as the metadata fields are not inside the |
We already have a feature in place that parses |
Note that the ( |
Anyone else have any thoughts on if the fork_version, network_name, genesis_validators_root, and deposit_cli_version be part of the messages in the array or have this array wrapped by something with that metadata 🤔 |
Thanks for the feedback! @mcdee @paulhauner @lucassaldanha: understand, I added @james-prysm good point 👍 I think it will be more clear when reading the file and for clients to integrate with it. Updated with this change. Also, with ethereum/consensus-specs#3206 change, I removed |
I think Ethdo has validator index as a string instead of an integer, can this also be string? or should we support both? https://github.com/attestantio/go-eth2-client/blob/master/spec/capella/blstoexecutionchange.go |
Not support both -- it should be specified which. Pointless flexibility is pointless and costly. |
Ah yes, good spot. This should be a string as the beacon REST API expects all integers to be quoted strings. |
@james-prysm @tersec @mcdee |
Proposal
staking-deposit-cli
will generate abls_to_execution_change-{timestamp}.json
file which includes theSignedBLSToExecutionChange
fields and the meta for debugging. The idea is to allow the stakers to import this JSON file to theSignedBLSToExecutionChange
pool of their beacon node (BN) with BN commands.Seek client teams' feedback on the process and format design. 🙏
2023/01/27 updated: addressed #312 (comment)
2023/01/17 updated: fixed JSON schema
2023/01/16 updated: removed
fork_version
, added '0x'-prefix to hex strings, and add "metadata" field.JSON schema
The current schema is:
message
andsignature
are required forSignedBLSToExecutionChange
.fork_version
,network_name
,genesis_validators_root
, anddeposit_cli_version
are for debugging.For example (it's not the real testable mainnet sig):
NOTE:
No0x
-prefix for the bytes fields here since thedeposit_data-*
file doesn't have it as well.The text was updated successfully, but these errors were encountered: