Use evmc::MockedHost moar #7831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
requested review from
axic,
chriseth and
christianparpart
and removed request for
axic
|
If these things are part of EVMC anyway, then we should use them! |
It was added lately: ethereum/evmc#334 |
|
Some older clang fails on this: https://travis-ci.org/ethereum/solidity/jobs/618167425 |
|
Rebased on develop and fixed my original commit message. Before merging, we should update to EVMC master which:
|
axic
force-pushed
the
mocked-host
branch
2 times, most recently
from
6e1c67d
to
0210080
Compare
chfast
commented
Dec 2, 2019
|
Compared to #7854, which ran It is a 7% time reduction. |
axic
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses some data structs and features already defined in
evmc::MockedHostinEVMHostimplementation. It is up to discussion if this should be continued and if the direction is right in general.Depends on #7848.