Allow enums in interfaces #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we would be able to work much faster if everyone had access to @axic's local repository ;) |
chriseth
approved these changes
Aug 7, 2018
axic
commented
Aug 7, 2018
| } | ||
| } | ||
| )"; | ||
| compileAndRun(sourceCode, 0, "C"); |
There was a problem hiding this comment.
I am not sure library linking is implemented in the test suite?
There was a problem hiding this comment.
Actually I think it is not.
chriseth
reviewed
Aug 7, 2018
| { | ||
| char const* sourceCode = R"( | ||
| interface I { | ||
| enum Direction { Left, Right } |
There was a problem hiding this comment.
Perhaps it would be better to use enum Direction { A, B, Left, Right} so that the return values show whether the interface or the library enum was used.
chriseth
force-pushed
the
interface-enum
branch
from
5c4e1b7 to
34a711a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4731 +/- ##
===========================================
+ Coverage 87.53% 87.54% +<.01%
===========================================
Files 313 313
Lines 30792 30798 +6
Branches 3660 3658 -2
===========================================
+ Hits 26954 26961 +7
Misses 2585 2585
+ Partials 1253 1252 -1
|
chriseth
approved these changes
Aug 7, 2018
|
@axic good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4087