Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set include paths in LSP. #12469

Closed
wants to merge 1 commit into from
Closed

Allow to set include paths in LSP. #12469

wants to merge 1 commit into from

Conversation

chriseth
Copy link
Contributor

No description provided.

Marenz
Marenz approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@Marenz Marenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to keep the TODO comments, then LGTM

@chriseth chriseth marked this pull request as draft January 3, 2022 21:04
@chriseth
Copy link
Contributor Author

chriseth commented Jan 3, 2022

Please don't approve a PR that changes an external interface and has zero tests.

@chriseth
Copy link
Contributor Author

Replaced by #12994

@chriseth chriseth closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marenz Marenz Marenz approved these changes

@christianparpart christianparpart Awaiting requested review from christianparpart

@cameel cameel Awaiting requested review from cameel

Assignees
No one assigned
Labels
language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriseth @Marenz @cameel