Merge `develop` into `breaking` #12202

cameel · 2021-10-27T13:37:13Z

The main reason for updating the branch is that I want to see if the t_ems_ext_hardhat job added in #12165 will pass on breaking too.

…k trace

…ully qualified library name

…ut modes

- SemanticTests accepts fully qualified library name and also unqualifed library name when the library is defined in the same file for convenience. - commandline tests are added! Signed-off-by: soroosh-sdi <soroosh.sardari@gmail.com>

Remove linking to unqualified library name

Template code for disallowing options in input modes that do not support them (handles `--error-recovery`)

[Docs] Fix formatting of the "security fixes" link on the main page

Fix typo in ir-breaking-changes.rst

Fix typo compiler->constructor.

Co-authored-by: shikharvashistha <shikharvashistha@yandex.com> Co-authored-by: cameel <kamil.sliwak@codepoets.it>

[CI] Store yul-phaser as an artifact

[CI] Run hardhat tests as a PR check

…command [CI] Reusable command for gitter notifications

Added different colors for warning & error

Do not use named function labels if function names are not unique.

Assert and stack traces for Bash scripts

…dition Add missing condition to `gitter_notify` command

…arding-fqln Clarify that `linkersymbol()` accepts but does not require a fully qualified library name

[SMTChecker] Report contract invariants

[trivial] Sort bugfixes in changelog

This is to avoid a assert from failing for forward declared user defined value types.

And added a proper error message when constant types containing (nested) mapping types are used.

chriseth · 2021-10-27T13:46:12Z

Oh! The use-after-free is in develop?? I'll fix it right away.

cameel · 2021-10-27T13:49:20Z

CI seems to be failing for the same reason as the last time (#11840 (comment)).

Last time I reported it to CircleCI and this is how I described the situation (after some back and forth to provide more details):

The scheduled t_ubu_ossfuzz (816229) finished at 1:45 UTC but then there was another run ~5h later and you can see in the header that it was not a scheduled one: t_ubu_ossfuzz (816230). The workflow page only links to the earlier one.

So it looks like there was some glitch that associated the nightly run with the PR. The PR was different from usual PRs in that it was not associated with a short-lived feature branch. It was instead merging the main branch (develop) into another long-lived branch (breaking). Scheduled nightly workflows also run on develop so there might be some connection here.

The main part of the response I got was this:

I'm passing on this information to the team actively working on the issue, as mentioned by my colleague Aaron.
For now I'm putting this ticket on hold until we get an update from our software engineers regarding the implementation of a fix.
There's no need to reply right now. You will be notified automatically when the status of your issue is updated by CircleCI.

I haven't heard anything on the issue since then. Apparently the bug is still present. If my assessment is correct then a workaround is to simply merge something into develop. It will rerun the CI with correct jobs.

chriseth · 2021-10-27T13:50:55Z

Fix is here: #12203

cameel · 2021-10-27T13:51:53Z

Oh! The use-after-free is in develop?? I'll fix it right away.

Yeah. It's not the first time this happens - some jobs that run outside of PRs have no notifications so we usually don't notice. I have a PR that adds notifications to them: #12174.

Moved storage size assert to TypeChecker from DeclarationTypeChecker

Fix wrong path to isoltest in docs

Fix use-after-free bug.

cameel · 2021-10-27T14:44:01Z

Looks like t_ems_ext_hardhat passed.

EDIT: Ah, wait. That's on develop. The job will run on breaking only after this PR is merged.

cameel · 2021-10-27T17:18:20Z

The Hardhat test finally ran on breaking and passed.

The workflow as a whole did not pass though. There's some unrelated breakage.

cameel · 2022-01-17T19:14:56Z

I just got a notification from CircleCI that the issue from #12202 (comment) has been fixed. So, hopefully, no more nightly workflow running on develop :)

cameel and others added 30 commits October 14, 2021 18:55

common.sh: printStackTrace() and assertFail()

9aad8d6

common.sh: Print the source code from locations indicated in the stac…

b85172b

…k trace

common.sh: Adjust formatting in msg_on_error() and add stack trace

3b1b9a0

Use fail and assertFail where appropriate in command-line tests

0280c8d

yul.rst: Clarify that linkersymbol() accepts but does not require a f…

d846410

…ully qualified library name

Disallowed --error-recovery in Standard json, Assembly and Linker inp…

b28e5c8

…ut modes

Do not use named function labels if function names are not unique.

9f48b74

Remove linking to unqualified library name

816d802

- SemanticTests accepts fully qualified library name and also unqualifed library name when the library is defined in the same file for convenience. - commandline tests are added! Signed-off-by: soroosh-sdi <soroosh.sardari@gmail.com>

Merge pull request #12073 from soroosh-sdi/unqualified-lib-name-bug

2b0fbc3

Remove linking to unqualified library name

Fix formatting

2278673

Merge pull request #11909 from Midhun07/develop

72b88da

Template code for disallowing options in input modes that do not support them (handles `--error-recovery`)

Merge pull request #12162 from fulldecent/patch-24

ef21e43

[Docs] Fix formatting of the "security fixes" link on the main page

CI: Store yul-phaser as an artifact too

92f3d74

Fix typo in ir-breaking-changes.rst

921d044

Add a PR check that runs hardhat tests using the built compiler binary

ab31437

Merge pull request #12178 from Gyeonghun-Park/develop

3774955

Fix typo in ir-breaking-changes.rst

CI: Refactor the gitter notification templates into a reusable command

0e71c12

CI: Use markdown link syntax in gitter messages

a4fce30

Fix typo compiler->constructor.

3387e13

Merge pull request #12184 from abliss/patch-1

ec52908

Fix typo compiler->constructor.

Added different colors for warning & error

cf00536

Co-authored-by: shikharvashistha <shikharvashistha@yandex.com> Co-authored-by: cameel <kamil.sliwak@codepoets.it>

Merge pull request #12172 from ethereum/circleci-yul-phaser-artifact

d8d2c49

[CI] Store yul-phaser as an artifact

Merge pull request #12165 from ethereum/hardhat-tests-in-ci

ae0db91

[CI] Run hardhat tests as a PR check

Merge pull request #12182 from ethereum/circleci-gitter-notification-…

8460a65

…command [CI] Reusable command for gitter notifications

Merge pull request #11970 from shikharvashistha/colors

1da57d5

Added different colors for warning & error

Merge pull request #12139 from ethereum/nonamedlabelsifnotunique

e6e30f8

Do not use named function labels if function names are not unique.

Merge pull request #12142 from ethereum/bash-assert-and-stack-traces

2162039

Assert and stack traces for Bash scripts

Add missing condition to gitter_notify command

cc80f5e

Merge pull request #12190 from ethereum/fix-circleci-notification-con…

ed091d0

…dition Add missing condition to `gitter_notify` command

Merge pull request #12144 from ethereum/clarify-linkersymbol-docs-reg…

719b708

…arding-fqln Clarify that `linkersymbol()` accepts but does not require a fully qualified library name

Leo Alt and others added 15 commits October 26, 2021 11:30

Add invariants option to CLI and JSON

3118fb3

Add SMTCheckerTest isoltest option to ignore invariants

37215ff

Adjust errors script to also look for infos

a104443

Adjust ModelCheckerSettings in tools tests

2cbd496

SMTChecker tests

38b0cf7

CLI and JSON tests

4f823c6

Docs

d04ad57

Changelog

902a2e2

Merge pull request #11451 from ethereum/smt_report_invariants

401dd43

[SMTChecker] Report contract invariants

Sort bugfixes in changelog

f588dd3

Merge pull request #12194 from ethereum/sort-changelog

453f404

[trivial] Sort bugfixes in changelog

Moved storage size assert to TypeChecker from DeclarationTypeChecker

9428dbc

Moved a canBeStored assert for struct members to TypeChecker

51009c0

This is to avoid a assert from failing for forward declared user defined value types.

Moved a check related to constants to TypeChecker

8815d6f

And added a proper error message when constant types containing (nested) mapping types are used.

Fix wrong path to isoltest in docs

61519da

cameel self-assigned this Oct 27, 2021

Fix use-after-free bug.

dce13fb

chriseth added 3 commits October 27, 2021 16:12

Merge pull request #12186 from ethereum/fix-userdefined-ice

9be882c

Moved storage size assert to TypeChecker from DeclarationTypeChecker

Merge pull request #12201 from ethereum/docs-path-fix

e4a94b6

Fix wrong path to isoltest in docs

Merge pull request #12203 from ethereum/fixuseafterfreeside

7ebf71f

Fix use-after-free bug.

chriseth merged commit 8c6e5e5 into breaking Oct 27, 2021

cameel mentioned this pull request Nov 10, 2021

Fix gitter notifications for non-PR runs in CI #12269

Merged

cameel mentioned this pull request Apr 20, 2023

Fix text formatting of CI matrix notifications #14090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge `develop` into `breaking` #12202

Merge `develop` into `breaking` #12202

cameel commented Oct 27, 2021

chriseth commented Oct 27, 2021

cameel commented Oct 27, 2021 •

edited

Loading

chriseth commented Oct 27, 2021

cameel commented Oct 27, 2021

cameel commented Oct 27, 2021 •

edited

Loading

cameel commented Oct 27, 2021

cameel commented Jan 17, 2022

Merge develop into breaking #12202

Merge develop into breaking #12202

Conversation

cameel commented Oct 27, 2021

chriseth commented Oct 27, 2021

cameel commented Oct 27, 2021 • edited Loading

chriseth commented Oct 27, 2021

cameel commented Oct 27, 2021

cameel commented Oct 27, 2021 • edited Loading

cameel commented Oct 27, 2021

cameel commented Jan 17, 2022

Merge `develop` into `breaking` #12202

Merge `develop` into `breaking` #12202

cameel commented Oct 27, 2021 •

edited

Loading

cameel commented Oct 27, 2021 •

edited

Loading