External tests for sushiswap/trident #12197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
update-gnosis-ext-test
branch
from
555ea65 to
d2c01aa
Compare
cameel
force-pushed
the
trident-ext-test
branch
from
a2f4abf to
c4a2fd8
Compare
|
cameel
force-pushed
the
trident-ext-test
branch
from
c4a2fd8 to
e6b7146
Compare
cameel
force-pushed
the
update-gnosis-ext-test
branch
2 times, most recently
from
6b41eae to
9f695dc
Compare
cameel
force-pushed
the
trident-ext-test
branch
from
e6b7146 to
05101ce
Compare
cameel
force-pushed
the
update-gnosis-ext-test
branch
from
9f695dc to
217b998
Compare
cameel
force-pushed
the
trident-ext-test
branch
from
05101ce to
b97b03b
Compare
cameel
force-pushed
the
update-gnosis-ext-test
branch
from
217b998 to
e4037d8
Compare
cameel
force-pushed
the
trident-ext-test
branch
from
b97b03b to
a816f17
Compare
cameel
force-pushed
the
update-gnosis-ext-test
branch
from
e4037d8 to
6e03d91
Compare
cameel
force-pushed
the
trident-ext-test
branch
from
a816f17 to
50637bd
Compare
cameel
force-pushed
the
update-gnosis-ext-test
branch
from
6e03d91 to
a04ef39
Compare
cameel
force-pushed
the
trident-ext-test
branch
2 times, most recently
from
d1d65c1 to
ab154bc
Compare
cameel
force-pushed
the
trident-ext-test
branch
from
ab154bc to
f3067d4
Compare
|
This now works, though not without workarounds:
|
cameel
force-pushed
the
trident-ext-test
branch
from
f3067d4 to
5b823b4
Compare
cameel
changed the base branch from
update-gnosis-ext-test
to
hardhat-in-oz-ext-test
cameel
force-pushed
the
trident-ext-test
branch
from
5b823b4 to
8626c2a
Compare
|
I got no feedback in sushiswap/trident#282 so far so it looks like it might not get merged in the near future. I adjusted the test script to solve the problem by patching upstream repo. This way we can track project's |
cameel
force-pushed
the
trident-ext-test
branch
from
3d7a97a to
ba55006
Compare
cameel
force-pushed
the
trident-ext-test
branch
5 times, most recently
from
96be215 to
6607e8f
Compare
cameel
force-pushed
the
trident-ext-test
branch
5 times, most recently
from
8091c66 to
3d5bcfd
Compare
hrkrshnn
previously approved these changes
Jan 3, 2022
Comment on lines
+81
to
+85
| sed -i 's|uint128(-1)|type(uint128).max|g' contracts/flat/BentoBoxV1Flat.sol | ||
| sed -i 's|uint64(-1)|type(uint64).max|g' contracts/flat/BentoBoxV1Flat.sol | ||
| sed -i 's|uint32(-1)|type(uint32).max|g' contracts/flat/BentoBoxV1Flat.sol | ||
| sed -i 's|IERC20(0)|IERC20(address(0))|g' contracts/flat/BentoBoxV1Flat.sol | ||
| sed -i 's|IStrategy(0)|IStrategy(address(0))|g' contracts/flat/BentoBoxV1Flat.sol |
There was a problem hiding this comment.
Mudit said bentobox is a legacy deployed contract, and they probably won't change it in the repo.
I just checked that there are no contract dependencies for Bento. So the project will still compile without this file, however, it's needed for tests. Fine with the sed.
There was a problem hiding this comment.
Yeah, unfortunately we really do want to run tests, not just compile. Especially now that #12441 requires a full test run to gather gas usage for the benchmark.
cameel
force-pushed
the
trident-ext-test
branch
from
3d5bcfd to
2d038cd
Compare
hrkrshnn
approved these changes
Jan 10, 2022
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an external test run for trident.
Unfortunately there is a problem: it uses mixed Solidity versions.
contracts/flat/BentoBoxV1Flat.solwants 0.6.12 and requires some minor changes to compile on 0.8.9 (some conversions and constructor visibility. We need a workaround for that or an upstream PR to make the contracts compatible with both versions.