Enforce constructor visibility #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
constructor-modifier
branch
from
b9a2177
to
370089f
Compare
| function test() constant {} | ||
| } | ||
| )"; | ||
| BOOST_CHECK(expectError(text, true) == Error::Type::SyntaxError); |
|
LGTM |
|
Oh we need to include this in the changelog. |
chriseth
force-pushed
the
constructor-modifier
branch
from
5bac37c
to
65c4e65
Compare
axic
pushed a commit
that referenced
this pull request
Nov 20, 2018
…itors, cross-links, links, grammar, etc. (#1019) * EIP-1 minors edits: clarify some sections on EIP collaborators and editors, cross-links, links, grammar, etc. * Add a link for [Ethereum philosophy](https://github.com/ethereum/wiki/wiki/White-Paper#philosophy) to the section in the white paper that was originally removed and which I re-added recently. * Revise the format for the author header (names can be optional for anonymity). * History edits (link to revision history + a minor edit). * Add cross-links to other sections for better readability and clarity. * Add clarifications on approval before merging from both editors and authors. * Add more links for discussion channels * Link to other clients and eips.ethereum.org. * Reorder EIP editors roughly based on recent contributions. * Other minor edits: grammar, etc. * Add a link to core dev meetings * discussion*s*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979