Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checksum error message #2094

Closed
chriseth opened this issue Mar 28, 2017 · 3 comments
Closed

Improve checksum error message #2094

chriseth opened this issue Mar 28, 2017 · 3 comments

Comments

@chriseth
Copy link
Contributor

chriseth commented Mar 28, 2017 •
edited
Loading

The address checksum error message is not understandable to people who do not know the checksum algorithm or concept.

We should link the EIP (ethereum/EIPs#55) and provide the correct checksum for addresses in all-caps or all-lowercase.

Related: #2092
@siblingzconsult
Copy link

Please clarify;do you feel that we should link the checksum for the entire EIP Structure in the same Caps?[Upper Caps or LowerCaps]?

AnthonyAkentiev added a commit to goldmint/gm-dapp that referenced this issue Sep 16, 2017
@AnthonyAkentiev
Fix addresses: ethereum/solidity#2094
31f6066
@chriseth
Copy link
Contributor Author

This is just about modifying the error message string to include the link.

@wadealexc wadealexc mentioned this issue Oct 5, 2017
Merged
@axic
Copy link
Member

axic commented Oct 5, 2017

It should actually link to https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md or perhaps a section in the Solidity documentation.

@axic axic mentioned this issue Oct 10, 2017
Merged
@axic axic closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axic @siblingzconsult @chriseth