-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add typings to npm package #693
base: master
Are you sure you want to change the base?
Conversation
maybe need |
Any update to this PR? 👀 |
Happy to help land this pr if any changes are requested |
Thank you for working on this. We are also running into this issue. cc @r0qs for code review if you don't mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @roninjin10, and sorry for the very late reply, let's do this. Could you please just add the following:
--- i/package.json
+++ w/package.json
@@ -3,6 +3,7 @@
"version": "0.8.28",
"description": "Solidity compiler",
"main": "index.js",
+ "types": "index.d.ts",
"bin": {
"solcjs": "solc.js"
},
However, please note that this will not fully expose all types, as there is still some missing support that needs to be implemented: #615. Nevertheless, it is a step in the right direction, and I believe there is no harm in taking this as a first step.
I got some types here that I have been using past couple years for Tevm. Anyone is free to copy https://github.com/evmts/tevm-monorepo/blob/main/bundler-packages/solc/src/solcTypes.ts |
@r0qs I did your change happy to rebase or do any other changes you need |
Yes, could you please squash and rebase. :) |
declaration: true
in tsconfig