This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Refactor remix lib - remix-debug, remix-analyzer #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
refactor_remix_lib2
branch
2 times, most recently
from
3af34b2 to
c2a9b1b
Compare
yann300
force-pushed
the
refactor_remix_lib2
branch
from
c2a9b1b to
8834639
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes of this PR are about moving code from remix-lib to remix-debug (TraceManager, CodeManager, ...).
Some helpers and utils that are only used for unit testing are duplicated among projects in order to remove dependency over remix-lib.
That said, some module like
Web3VmProviderare still used across different projects (remix-debug and remix-simulator) - this could be addressed in a different PR.