Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar and Style Improvements in Team Best Practices #5484

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Dahka2321
Copy link
Contributor

Changes Made in apps/remix-ide/team-best-practices.md:

  1. Line 61:
  • Before starting coding, we should ensure all devs / contributors are aware of:
  • Before starting to coding, we should ensure all devs / contributors are aware of:

Reason: Improved grammatical structure for better readability.

  1. Line 90:
  • You should not expect complete review on a pull request which is not passing CI.
  • You should not expect a complete review on a pull request which is not passing CI.

Reason: Added missing article "a" for proper grammar.

  1. Line 112:
  • Ideally You should have enough knowledge to be able to fix related bugs.
  • Ideally you should have enough knowledge to be able to fix related bugs.

Reason: Corrected capitalization - "You" should not be capitalized mid-sentence.

  1. Line 146:
  • After a new release we should stay in alert for possible regression and better not release Friday at 5pm :)
  • After a new release we should stay in alert for possible regression and better not release on Friday at 5pm :)

Reason: Added preposition "on" for proper temporal expression.

  1. Line 200:
  • this announcement should be specially marked so ppl can check early
  • this announcement should be specially marked so people can check early

Reason: Replaced informal abbreviation "ppl" with proper word "people" for professional documentation.

Copy link

netlify bot commented Dec 10, 2024

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 94a8c60

@Aniket-Engg Aniket-Engg merged commit 3079c61 into ethereum:master Dec 11, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants