Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI required to support markdown #5423

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

iamsethsamuel
Copy link
Contributor

So I noticed the AI writes all the codes in plain text thereby make nlux/react not able to highlight code properly

Screenshot 2024-11-26 at 12 47 05

So I added a prompt at the end to ensure the code is properly formated in markdown

image

Copy link

netlify bot commented Nov 26, 2024

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 33a3c51

@LianaHus LianaHus requested a review from STetsing November 26, 2024 12:33
@iamsethsamuel
Copy link
Contributor Author

Seems like STetsing isn’t online to review the PR

@STetsing
Copy link
Collaborator

STetsing commented Dec 2, 2024

Code snippets in the chatbox should be in a markdown format. I adding that prompt enforce the llm more to produce such, good

@iamsethsamuel
Copy link
Contributor Author

Seems like STetsing isn’t online to review the PR

Ohhh. I tried it severally and it wasn't formatting it properly. I posted a screenshot above

@STetsing
Copy link
Collaborator

STetsing commented Dec 2, 2024

@iamsethsamuel how did you try it? You have to wait until the end of streaming

@iamsethsamuel
Copy link
Contributor Author

@iamsethsamuel how did you try it? You have to wait until the end of streaming

Yes sir, I did

@STetsing
Copy link
Collaborator

STetsing commented Dec 2, 2024

Markdown is already available,
can't reproduce the scenario/issue in the image above, since not related to prompt engineering. Something else might be the cause

@STetsing STetsing self-requested a review December 2, 2024 11:31
@iamsethsamuel
Copy link
Contributor Author

Markdown is already available, can't reproduce the scenario/issue in the image above, since not related to prompt engineering. Something else might be the cause

Yeah

Copy link
Collaborator

@STetsing STetsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown is already available, LLM chars Misalignment suspected when starting with markdown

@iamsethsamuel
Copy link
Contributor Author

Markdown is already available, LLM chars Misalignment suspected when starting with markdown

But if the LLM is producing differing results. Don't you think it's best to force it to always produce the properly formatted markdown results?

@Aniket-Engg Aniket-Engg merged commit eb08f18 into ethereum:master Dec 2, 2024
25 of 28 checks passed
@iamsethsamuel iamsethsamuel deleted the ai-code-format branch December 2, 2024 13:52
@STetsing
Copy link
Collaborator

STetsing commented Dec 5, 2024

@Aniket-Engg this must be reverted, it causes all prompts to be weird formatted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants