fix containers, direct to field sedes elements, not the pair containing them #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nvm, had incorrect Container instantiation, which resulted in the tuple wrapping of fields. |
pacrob
added a commit
to pacrob/py-ssz
that referenced
this pull request
Apr 14, 2023
bump docs dependencies, add readthedocs requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
fields_sedesis a series of(name, sedes), not justsedes. The code however, expectedsedesin some places.Stumbled on it with work on ethereum/consensus-specs#1178
How was it fixed?
Simply unpack the pair, and get the
sedesfrom it.Cute Animal Picture