Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #195 custom genesis_data #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4gn3s
Copy link

@4gn3s 4gn3s commented Nov 22, 2016

Cute Animal Picture

wild pig

@pipermerriam
Copy link
Member

I've now made the appropriate changes to how project configuration works that this can be done in a more sane way. I'd propose doing this via the new project configuration API (which just landed in master and doesn't really have very good documentation). The first idea that comes to mind would involve using a configuration file with a section like the following.

{
  "chains": {
    "my-chain": {
      "geth": {
        "genesis": {
          "difficulty": "0x1",
          ...
        }
      }
    }
  }
}

The Project.get_chain function still allows passing through *args, **kwargs into a chain but looking at the code it looks like I may have broken that API. I'm interested in deprecating that API in favor of moving entirely over to a configuration based approach. Something like allowing you to pass a custom configuration into Project.get_chain that would override the chain configuration in your config file. This could be used for temp chains as well as running one of the pre-configured chains with a slightly different configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants