This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Upgrade to web3.js 1.0.0 with subscription support #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available for subscription handling fix in Mist
…o web3.js-1.0.0 # Conflicts: # app/.meteor/versions # app/client/templates/views/account.js
|
when viewing in firefox, i can see the "add account" button. clicking on it produces the console errors: |
…pp-wallet into web3.js-1.0.0
…xt. Also, if no peers, show 'Connecting...' text instead of blank peers
…pp-wallet into web3.js-1.0.0
…pp-wallet into web3.js-1.0.0
…pp-wallet into web3.js-1.0.0
alexvandesande
approved these changes
May 21, 2018
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades meteor-dapp-wallet to use web3.js 1.0.0
The primary benefit is using subscriptions instead of filters, which results in much fewer web3 calls.
Currently waiting for subscription support in MetaMask before merging to not break wallet.ethereum.org for MetaMask users.
Checklist:
For testing, it would be great to help test in both Mist and any other browser with geth in websockets mode (
geth --ws --wsorigins "*"). I would appreciate testing: sending transactions, sending erc20 tokens, creating wallets, sending transactions to/from wallets, watching contracts, deploying contracts.