Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with rust-verkle's proof format #181

Merged
merged 7 commits into from
Jan 28, 2022

Conversation

gballet
Copy link
Member

@gballet gballet commented Jan 27, 2022

Changes introduced by this PR:

  • For an easier decoding of the proof, the keys and values are moved to their own field in the block. For this to happen, proof and keyvals are no longer serialized as a single block;
  • It serializes the de-duplicated commitments by path, and no longer by (commitment, zi) tuples;
  • It fixes some issues that got introduced with change the return type of offset2key to byte #102

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #181 (84f52a2) into master (351986d) will increase coverage by 0.68%.
The diff coverage is 95.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   88.30%   88.98%   +0.68%     
==========================================
  Files           9        9              
  Lines         906      908       +2     
==========================================
+ Hits          800      808       +8     
+ Misses         78       75       -3     
+ Partials       28       25       -3     
Impacted Files Coverage Δ
proof_ipa.go 90.08% <89.28%> (+3.82%) ⬆️
config.go 100.00% <100.00%> (ø)
encoding.go 84.61% <100.00%> (+0.30%) ⬆️
stateless.go 83.57% <100.00%> (ø)
tree.go 91.57% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351986d...84f52a2. Read the comment docs.

@gballet gballet changed the title Separate keys and proof in SerializeProof Compatibility with rust-verkle's proof format Jan 27, 2022
@gballet gballet requested a review from jwasinger January 27, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants