all: get rid of custom MaxUint64 and MaxUint64 #30636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested review from
fjl,
holiman,
gballet,
rjl493456442,
zsfelfoldi and
lightclient
as code owners
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 19, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 21, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 26, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our own
common/mathpackage had MaxInt64 and MaxUint64 redeclared. A bunch of code throughout go-ethereum used these instead of the stdlibmathvariants. This is bad because it introduces a pointless dependency from various packages tocommon(common/mathdepends oncommon, different story to break).Either way, whilst it may be nice to write
math.MaxUint64from code where we also mess withmath.MaxBigand other methods, it's really to little of a nicety gain for messing up dependencies. This PR removes these constants and just points all user code to stdlib math instead.